Skip to content

Clarify that span is only used for loess in stat_smooth #4261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 27, 2020

Conversation

nalimilan
Copy link
Contributor

@nalimilan nalimilan commented Nov 9, 2020

It can be surprising that span argument has no effect when number of observations is large (cf. #3174).

It can be surprising that `span` argument has no effect when number of observations is large.
@yutannihilation
Copy link
Member

You need to edit the original text and then re-generate the docs by devtools::document().

ggplot2/R/stat-smooth.r

Lines 26 to 28 in a132727

#' @param span Controls the amount of smoothing for the default loess smoother.
#' Smaller numbers produce wigglier lines, larger numbers produce smoother
#' lines.

@nalimilan
Copy link
Contributor Author

Ah of course, sorry!

Copy link
Member

@yutannihilation yutannihilation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, almost looks good to me! I added minor comments about spacing.

One more thing, Tidyverse team is trying to change the license of ggplot2 to more permissive one (the MIT license) to minimize the problems and confusions arising from license incompatibilities. If you are fine that your contribution will be merged to ggplot2 and get licensed under MIT, would you mind commenting "I agree" on #4231?

For more details, you can join the discussion on #4236, or wait for their upcoming blog post.

Co-authored-by: Hiroaki Yutani <yutani.ini@gmail.com>
@yutannihilation
Copy link
Member

/document

@yutannihilation yutannihilation merged commit 12e61df into tidyverse:master Nov 27, 2020
@yutannihilation
Copy link
Member

Thanks!

@nalimilan nalimilan deleted the patch-1 branch November 27, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants