-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Describe what is ymin, ymax #4215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Eric Leung <eric@erictleung.com>
Fixed also a tipo on stat_summary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Before I merge this, I need to ask you one more thing. Tidyverse team is trying to change the license of ggplot2 to more permissive one (the MIT license) to minimize the problems and confusions arising from license incompatibilities. If you are fine that your contribution will be merged to ggplot2 and get licensed under MIT, would you mind commenting "I agree" on #4281?
For more details, you can join the discussion on #4236.
I've been following the relicensing, and asked several questions on the usethis relicensing issue. I am still waiting for the blog post #4236 (comment) announced on October. |
Thanks for commenting there. Year, I too have been waiting for the blog post... |
Anyway, thanks for your contribution! |
Following this gist I discovered
mean_se
. However I think it is poorly documented.Also the error is not informative if someone provides a vector for mult:
I open this draft PR to know if something like this would be welcomed.