Skip to content

Describe what is ymin, ymax #4215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 14, 2020
Merged

Describe what is ymin, ymax #4215

merged 4 commits into from
Dec 14, 2020

Conversation

llrs
Copy link
Contributor

@llrs llrs commented Sep 30, 2020

Following this gist I discovered mean_se. However I think it is poorly documented.

Also the error is not informative if someone provides a vector for mult:

x <- rnorm(100)
mean_se(x, mult = c(1, 2)
## Error: Elements must equal the number of rows or 1

I open this draft PR to know if something like this would be welcomed.

@llrs llrs marked this pull request as ready for review November 12, 2020 11:55
Co-authored-by: Eric Leung <eric@erictleung.com>
Fixed also a tipo on stat_summary
Copy link
Member

@yutannihilation yutannihilation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Before I merge this, I need to ask you one more thing. Tidyverse team is trying to change the license of ggplot2 to more permissive one (the MIT license) to minimize the problems and confusions arising from license incompatibilities. If you are fine that your contribution will be merged to ggplot2 and get licensed under MIT, would you mind commenting "I agree" on #4281?

For more details, you can join the discussion on #4236.

@llrs llrs mentioned this pull request Dec 14, 2020
14 tasks
@llrs
Copy link
Contributor Author

llrs commented Dec 14, 2020

I've been following the relicensing, and asked several questions on the usethis relicensing issue. I am still waiting for the blog post #4236 (comment) announced on October.

@yutannihilation
Copy link
Member

Thanks for commenting there. Year, I too have been waiting for the blog post...

@yutannihilation yutannihilation merged commit 9deb97b into tidyverse:master Dec 14, 2020
@yutannihilation
Copy link
Member

Anyway, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants