Handle when geometry
is not a symbol
#4127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4122
Currently,
LayerSf$setup_layer()
usesas_name(self$mapping$geometry)
in the assumption thatgeometry
is a quosure of a symbol, which is not always the case. Possible fix would beand I chose option 2. because option 1. seems too much for this rare use case.
Created on 2020-07-10 by the reprex package (v0.3.0)