Annotation logticks outside #3783
Conversation
let ticks be outside of plot
|
Please merge in master so the CI doesn't break anymore. Thanks! |
|
Last step is to add a small note on the new feature to the |
NEWS.md
Outdated
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| # ggplot2 3.3.0 | |||
|
|
|||
| * Added an `outside` option to `annotation_logticks()` that places tick marks | |||
| outside of the plot bounds. (#3783, @kbodwin) | |||
There was a problem hiding this comment.
Thanks for making this change. Unfortunately I'll have to request one more modification. I think your news item is in the wrong location in the News file. This feature won't make it into ggplot2 3.3.0, as that version has already been branched off.
Could you move your entry to above the ggplot2 3.3.0 heading?
…win/ggplot2 into annotation_logticks_outside
R/annotation-logticks.r
Outdated
| @@ -7,6 +7,9 @@ | |||
| #' @param sides a string that controls which sides of the plot the log ticks appear on. | |||
| #' It can be set to a string containing any of `"trbl"`, for top, right, | |||
| #' bottom, and left. | |||
| #' @param outside logical that controls whether to move the log ticks outside | |||
| #' of the plot area. Default is off (FALSE). You will also need to use | |||
There was a problem hiding this comment.
Apologies, one last thing (I promise): Please put FALSE into backticks.
|
@clauswilke and @kbodwin do you want to finish this off? |
|
@kbodwin Please let me know if you're in a position to resolve the conflict and make the final edit. Otherwise I can probably go into your PR and make the final changes myself. |
|
Done; sorry to miss that last tweak. |
|
Thanks! |
Allows logticks to be outside of plotting pane, when used with
coord_cartesian(clip = "off")Fixes #3660