Extend the range of recognised positional aesthetics #3168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clauswilke
approved these changes
Mar 1, 2019
|
By the way, these (what aesthetics are treated as positional) are the official spec of ggplot2? If so, I think it should be described in the docs (and I'll do it in a seperate PR). |
|
You can see the list of recognised position aesthetics in the construction of the continuous position scales... |
|
Yeah, but I still think it's nice to have it documented (and probably needs tests), though I have no idea where those developer-only documentaton should go (Extending ggplot2?)... |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the recognised positional aesthetics to include
x0andy0. This is needed for a range of geoms/stats in ggforce to make sure they play nice with scale transformations.x0andy0are traditionally used to denote center values and a natural fit for many parametrised geometries...Such a change has happened before in c9f276b so it should be fairly safe