Conversation
|
This fixes #2718 at last. Thanks Thomas! |
|
This looks good to me in principle, but I don't have time this week to go over it in detail (proofing my book this week, and likely reformatting many of the figures). I think increasing the required sf version is good anyways, because otherwise axis ticks may be placed in the wrong location due to a pernicious bug that was only recently fixed. |
yutannihilation
left a comment
yutannihilation
left a comment
There was a problem hiding this comment.
Minor comments.
By the way, it's not necessarily included in this PR, but can we add some simple tests about the gpar() is built as intended?
R/geom-sf.R
Outdated
| } | ||
| geometry <- x$geometry | ||
| type <- sf_types[sf::st_geometry_type(geometry)] | ||
| is_point <- type %in% 'point' |
There was a problem hiding this comment.
Use ", not ', as the style guide says: https://style.tidyverse.org/syntax.html#quotes
There was a problem hiding this comment.
Oops - nice catch. My life is a constant struggle between my own preference and Hadleys ;-)
| type <- sf_types[sf::st_geometry_type(geometry)] | ||
| is_point <- type %in% 'point' | ||
| type_ind <- match(type, c('point', 'line', 'other')) | ||
| defaults <- list( |
There was a problem hiding this comment.
We will need to re-think this at some point in order to expose to the user in the same way as other geoms. But we don't need to do that in this PR.
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
4 participants
This PR adapts
geom_sfandcoord_sfto make use of the improvements in performance introduced in sf v0.7-3. The changes are as follows:st_normalizeduring rescaling to greatly speed up `coord_sfsfdecide on how/if to split it up to multiple grobsThis PR introduces a new version dependency on sf as it does not make much sense to support both implementations simultaneously