Skip to content

Commit d9c902b

Browse files
yutannihilationthomasp85
authored andcommitted
Compare facet params instead of the whole objects (#4294)
1 parent 448bea0 commit d9c902b

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

tests/testthat/test-facet-.r

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -125,10 +125,10 @@ test_that("facet_grid() accepts vars()", {
125125
expect_identical(grid$params$rows, quos(foo = foo))
126126
expect_identical(grid$params$cols, quos(bar = bar))
127127

128-
expect_equal(facet_grid(vars(am, vs)), facet_grid(am + vs ~ .))
129-
expect_equal(facet_grid(vars(am, vs), vars(cyl)), facet_grid(am + vs ~ cyl))
130-
expect_equal(facet_grid(NULL, vars(cyl)), facet_grid(. ~ cyl))
131-
expect_equal(facet_grid(vars(am, vs), TRUE), facet_grid(am + vs ~ ., margins = TRUE))
128+
expect_equal(facet_grid(vars(am, vs))$params, facet_grid(am + vs ~ .)$params)
129+
expect_equal(facet_grid(vars(am, vs), vars(cyl))$params, facet_grid(am + vs ~ cyl)$params)
130+
expect_equal(facet_grid(NULL, vars(cyl))$params, facet_grid(. ~ cyl)$params)
131+
expect_equal(facet_grid(vars(am, vs), TRUE)$params, facet_grid(am + vs ~ ., margins = TRUE)$params)
132132
})
133133

134134
test_that("facet_grid() fails if passed both a formula and a vars()", {

0 commit comments

Comments
 (0)