Skip to content

Commit a330da3

Browse files
Fill closed arrows in element_line() (#2924)
1 parent 960e3fb commit a330da3

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

NEWS.md

+2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@
99
* Aesthetic mappings now accept functions that return `NULL` (@yutannihilation,
1010
#2997)
1111

12+
* Closed arrows in `element_line()` are now filled (@yutannihilation, #2924).
13+
1214
# ggplot2 3.1.0
1315

1416
## Breaking changes

R/theme-elements.r

+9-3
Original file line numberDiff line numberDiff line change
@@ -226,9 +226,15 @@ element_grob.element_line <- function(element, x = 0:1, y = 0:1,
226226
default.units = "npc", id.lengths = NULL, ...) {
227227

228228
# The gp settings can override element_gp
229-
gp <- gpar(lwd = len0_null(size * .pt), col = colour, lty = linetype, lineend = lineend)
230-
element_gp <- gpar(lwd = len0_null(element$size * .pt), col = element$colour,
231-
lty = element$linetype, lineend = element$lineend)
229+
gp <- gpar(
230+
col = colour, fill = colour,
231+
lwd = len0_null(size * .pt), lty = linetype, lineend = lineend
232+
)
233+
element_gp <- gpar(
234+
col = element$colour, fill = element$colour,
235+
lwd = len0_null(element$size * .pt), lty = element$linetype,
236+
lineend = element$lineend
237+
)
232238
arrow <- if (is.logical(element$arrow) && !element$arrow) {
233239
NULL
234240
} else {

0 commit comments

Comments
 (0)