Skip to content

error if eval_time is needed and missing when calling augment() #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

EmilHvitfeldt
Copy link
Member

What the title says. to close #988.

I didn't add anything to NEWS since it already has a bullet that says augment() now works for censored regression models.

@EmilHvitfeldt
Copy link
Member Author

pkgdown failure is related to #990

@topepo
Copy link
Member

topepo commented Jul 19, 2023

@hfrick or I will add a test case for this in an upcoming PR. Thanks.

@topepo topepo self-requested a review July 19, 2023 16:29
@hfrick
Copy link
Member

hfrick commented Jul 19, 2023

I'll look at Emil's test PR: tidymodels/extratests#103

@topepo topepo merged commit 42d0cf5 into main Jul 20, 2023
@topepo topepo deleted the augment-missing-eval_time branch July 20, 2023 21:20
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleaner error for augment() with survival models
3 participants