store y_var
in fit output from xy interface when available
#961
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to tidymodels/workflows#131. That issue notes that
augment.workflow()
doesn't return.resid
as does the equivalent model fit fromaugment.model_fit()
, even though it calls themodel_fit
methods in its internals. This is because workflows always(?) transitions to the xy interface before handing data off to parsnip. I came across this while putting together the companion PR to #960.While the xy machinery makes use of the
..y
placeholder in its internals, we can append the actual names attached toy
—that are, at least in the workflows case, still intact—asy_var
to the resultingmodel_fit
so that we can reference that column later.In combination with a workflows PR that will follow up on this one,
augment.workflow()
will return residuals in the situations thataugment.model_fit()
does!