Skip to content

warn with >2 levels on logistic_reg() fit #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2023
Merged

warn with >2 levels on logistic_reg() fit #916

merged 2 commits into from
Mar 10, 2023

Conversation

simonpcouch
Copy link
Contributor

Closes #545.🐧 Warns rather than errors since some engines bin the non-first-level outcome levels as the non-event.

Locating this check inside of check_outcome rather than translate.logistic_reg() since we don't yet have access to the outcome at the point. :/

@simonpcouch simonpcouch requested a review from hfrick March 9, 2023 19:35
Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoop! 🐬

@simonpcouch simonpcouch merged commit 9dcfcf0 into main Mar 10, 2023
@simonpcouch simonpcouch deleted the logistic-545 branch March 10, 2023 13:21
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parsnip should raise an error when users use logistic_reg() for multiclass classification
2 participants