Skip to content

address knitr installation dependency #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 19, 2022
Merged

address knitr installation dependency #790

merged 4 commits into from
Aug 19, 2022

Conversation

simonpcouch
Copy link
Contributor

Copies knitr::combine_words and friends to close #785.

Could you confirm this does the trick for you, @mdneuzerling?

@mdneuzerling
Copy link

Thank you so much for the quick response, @simonpcouch! My Docker image now builds successfully — without knitr — so I think we can consider #785 solved.

@simonpcouch
Copy link
Contributor Author

Awesome, glad to hear it!

@simonpcouch simonpcouch requested a review from hfrick August 16, 2022 11:32
@simonpcouch
Copy link
Contributor Author

Opted instead to introduce a light wrapper around glue::glue:collapse, which is already an Imports:

parsnip:::combine_words(1)
#> [1] "1"
parsnip:::combine_words(1:2)
#> [1] "1 and 2"
parsnip:::combine_words(1:3)
#> [1] "1, 2, and 3"
parsnip:::combine_words(1:4)
#> [1] "1, 2, 3, and 4"

Created on 2022-08-18 by the reprex package (v2.0.1)

Will wait to fix merge conflicts until the updated NEWS.md is on main. :)

@simonpcouch simonpcouch merged commit 7ed006d into main Aug 19, 2022
@simonpcouch simonpcouch deleted the knitr-dep-785 branch August 19, 2022 16:24
@github-actions
Copy link

github-actions bot commented Sep 3, 2022

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

knitr is an installation dependency under certain conditions
3 participants