Skip to content

align null_model() with other model types #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2024
Merged

align null_model() with other model types #1085

merged 2 commits into from
Apr 9, 2024

Conversation

simonpcouch
Copy link
Contributor

Closes #1083. :)

  • Adds an argument engine to null_model() with default "parsnip"
  • Checks inputs with new_model_spec()
  • Tests that result can be fitted without calling set_engine()
  • Uses documentation format for mode and engine that follows the same patterns for other model types

Related to #1009 but does not close: still some documentation work to do in another PR.

@simonpcouch simonpcouch requested a review from topepo March 21, 2024 16:02
@simonpcouch simonpcouch merged commit 7b7e118 into main Apr 9, 2024
@simonpcouch simonpcouch deleted the null-model branch April 9, 2024 20:54
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

null_model() requires the engine to be set in some cases, but doesn't allow an engine argument
1 participant