Cleaned up some code

Author: topepo

R/arguments.R

@@ -1,13 +1,10 @@
 #' @importFrom rlang eval_tidy is_quosure na_lgl lgl is_missing ll
 
-
-# `sub_arg_values`` takes an existing expression and substitutes 
+# `sub_arg_values` takes an existing expression and substitutes 
 # different argument values that are passed to it. `ignore` is 
 # an optional list of arguments that will not have their arguments 
 # substituted. 
 
-## TODO: test this with something containing ... in definition
-
 sub_arg_values <- function (expr, args, ignore = NULL)  {
   arg_names <- names(args)
   # Remove ignore

R/fit.R

@@ -1,7 +1,6 @@
 # General TODOs
-# - think about case weights in each instance below
-# - devise a unit test plan that does not add pkg deps for each model
-# - where/how to add data checks (e.g. factors for classification)
+# Q: think about case weights in each instance below
+# Q: where/how to add data checks (e.g. factors for classification)
 
 
 #' Fit a Model Specification to a Dataset

R/misc.R

@@ -1,16 +1,4 @@
 
-# make S3 with methods for vector, matrix, and recipe
-guess_mode <- function(y) {
-  if (inherits(y, c("character", "factor"))) {
-    res <- "classification"
-  } else if (inherits(y, "numeric")) {
-    res <- "regression"
-  } else if (inherits(y, "Surv")) {
-    res <- "risk regression"
-  } else res <- "unknown"
-  res
-}
-
 # Q: make classes for mode too? 
 make_classes <- function(prefix, mode) {
   cls <- c(paste(prefix, mode, sep = "."), prefix)
@@ -41,7 +29,11 @@ model_printer <- function(x, ...) {
   } 
   if (length(x$others) > 0) {
     cat("Engine-Specific Arguments:\n")
-    others <- lapply(x$others, function(x) paste(deparse(x), sep = "\n", collapse = "\n"))
+    others <- lapply(x$others,
+                     function(x)
+                       paste(deparse(x),
+                             sep = "\n",
+                             collapse = "\n"))
     others <- lapply(others, function(x)
       paste0("  ", x, "\n"))
     onms <- names(others)