Skip to content

survival model fit augmentation testing #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 18, 2023
Merged

survival model fit augmentation testing #93

merged 11 commits into from
Jul 18, 2023

Conversation

topepo
Copy link
Member

@topepo topepo commented May 4, 2023

This is dependent on tidymodels/parsnip#960

hfrick added 4 commits May 5, 2023 11:45
to match the order of args in `expect_equal()`: first  `object` then `expected`
Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few touch-ups and an additional test for when we do not get predictions of survival time 👍

Comment on lines +17 to +20
set.seed(2)
split <- initial_split(sim_dat)
sim_tr <- training(split)
sim_te <- testing(split)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is not relevant for testing augment(), I would remove it here to keep the tests focussed on the essentials.

@topepo topepo marked this pull request as ready for review May 5, 2023 15:52
@hfrick hfrick merged commit 09f1f28 into main Jul 18, 2023
@hfrick hfrick deleted the survival-augment branch July 18, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants