Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'none' authentication for kafka while still allowing SSL #706

Merged
merged 1 commit into from
Nov 20, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions internal/endpoint/kafka.go
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,24 @@ func (conn *KafkaConn) Send(msg string) error {
}

cfg.Net.TLS.Config = &tlsConfig
case "none":
// This path allows to either provide a custom ca certificate
// or, because RootCAs is nil, is using the hosts ca set
// to verify the server certificate
if conn.ep.Kafka.SSL {
tlsConfig := tls.Config{}

if conn.ep.Kafka.CACertFile != "" {
caCertPool, err := loadRootTLSCert(conn.ep.Kafka.CACertFile)
if err != nil {
return err
}
tlsConfig.RootCAs = &caCertPool
}

cfg.Net.TLS.Enable = true
cfg.Net.TLS.Config = &tlsConfig
}
}

c, err := sarama.NewSyncProducer([]string{uri}, cfg)
Expand Down
Loading