Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crashes under go1.14 runtime #562

Closed
rshura opened this issue May 19, 2020 · 2 comments
Closed

Crashes under go1.14 runtime #562

rshura opened this issue May 19, 2020 · 2 comments

Comments

@rshura
Copy link
Contributor

rshura commented May 19, 2020 •
edited
Loading

This is the runtime issue we encountered the hard way, through crashes of tile38:
golang/go#37688

The issue manifests with tile38 if the query contains TIMEOUT and WHEREVAL and the timeout gets triggered (query does not finish within the allotted timeout). After such queries, the next GC cycle crashes the server, exactly like the issue above.

Rebuilding with go1.14.3 fixed the issue for us. We can reliably crash 1.14 runtime and not crash with 1.14.3 runtime on the same code.
@rshura
Copy link
Contributor Author

rshura commented May 19, 2020 •
edited
Loading

There's nothing to fix in tile38 tree for this. But all the released binaries should not be built with go 1.14.

@tidwall
Copy link
Owner

tidwall commented May 20, 2020 •
edited
Loading

Yikes. That's good to know.
I just made sure that the official Github and Docker releases will be 1.14.3+

@tidwall tidwall closed this as completed May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tidwall @rshura