Handle background push without installation ID (#1066)

dinosaursrarr · web-flow · commit 5439bb88ec8e · 2024-05-02T15:26:50.000-04:00
Addressed #1003. Someone got confused enough to write in (and I don't blame them). Seems more user friendly to point out the problem than to silently do nothing.
diff --git a/cmd/push.go b/cmd/push.go
@@ -55,6 +55,10 @@ func push(cmd *cobra.Command, args []string) error {
 		installationID = args[2]
 	}
 
+	if background && len(installationID) == 0 {
+		return fmt.Errorf("Background push won't do anything unless you also specify an installation ID")	
+	}
+
 	if apiToken == "" {
 		apiToken = os.Getenv(APITokenEnv)
 	}

Original file line number	Diff line number	Diff line change
`@@ -55,6 +55,10 @@ func push(cmd *cobra.Command, args []string) error {`
`55`	`55`	`installationID = args[2]`
`56`	`56`	`}`
`57`	`57`
	`58`	`+ if background && len(installationID) == 0 {`
	`59`	`+ return fmt.Errorf("Background push won't do anything unless you also specify an installation ID")`
	`60`	`+ }`
	`61`	`+`
`58`	`62`	`if apiToken == "" {`
`59`	`63`	`apiToken = os.Getenv(APITokenEnv)`
`60`	`64`	`}`