Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Show map markers with labels #32

Closed
LeeKunTibia opened this issue Jun 28, 2018 · 3 comments
Closed

Feature Request: Show map markers with labels #32

LeeKunTibia opened this issue Jun 28, 2018 · 3 comments

Comments

@LeeKunTibia
Copy link

I was navigating the map today and found myself wondering what was island that was. The Map could have an option to show markers (the client markers would be enough), and then when hovering a popup with the name of the place would be displayed, possibly with a link to TibiaWiki.

Since it would be very time consuming to add marks at first, ideally they should be stored in a text format (e.g. json) so we can even edit and add new marks right here on GitHub, and then make the pull requests. I was thinking of something like:

{
 "X": 32078,
 "Y": 32441,
 "Z": 7,
 "Type": "Town",  // The marker type would be defined by this. 
 "Label": "Meluna",
 "Link": true
} 

This boolean true/false mode would only work if the label is identical to the Wiki page, but I think it's much simpler than parsing some sort of markdown inside the label, for example (but that would be ideal).

With this we could identify even small rooms, for example the exact room of each Inquisition boss. Since this could also pollute the map, perhaps there could a way to filter the markers you want to see (Towns, Boss, Hunting Area, etc).

I don't think I can do this by myself from scratch but I can try to help improving and of course adding the markers.

@mathiasbynens
Copy link
Member

We could potentially re-use the JSON files that stores the actual marker data: https://github.com/tibiamaps/tibia-map-data/blob/master/data/floor-07-markers.json

@Bernardoow
Copy link
Contributor

Bernardoow commented Aug 24, 2018

A few months ago I wrote this: https://github.com/Bernardoow/tibia-map/commits/markers. This can give a ideia how is the map with markers.

My modification using json from json of tibiamaps in gh-pages: https://bernardoow.github.io/tibia-map/#32368,32198,7:0

@mathiasbynens
Copy link
Member

This has been live for a while now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants