Skip to content

Commit b702be6

Browse files
authored
adjusting parsing of fansite page (#125)
updating fansite_test updating fansite testdata
1 parent c1c38f3 commit b702be6

File tree

3 files changed

+77
-83
lines changed

3 files changed

+77
-83
lines changed

src/TibiaFansitesV3.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ type FansitesResponse struct {
5757
var (
5858
FansiteInformationRegex = regexp.MustCompile(`<td><a href="(.*)" target.*img .*src="(.*)" alt="(.*)"\/><\/a>.*<a href=".*">(.*)<\/a><\/td><td.*top;">(.*)<\/td><td.*top;">(.*)<\/td><td.*top;">(.*)<\/td><td.*<ul><li>(.*)<\/li><\/ul><\/td><td.*top;">(.*)<\/td>`)
5959
FansiteImgTagRegex = regexp.MustCompile(`<img[^>]+\bsrc="([^"]+)"`)
60-
FansiteLanguagesRegex = regexp.MustCompile("iti__flag.iti__(..)")
60+
FansiteLanguagesRegex = regexp.MustCompile(`id="Language_([a-z]{2})`)
6161
FansiteAnchorRegex = regexp.MustCompile(`.*src="(.*)" alt=".*`)
6262
)
6363

@@ -141,7 +141,7 @@ func TibiaFansitesV3Impl(BoxContentHTML string) FansitesResponse {
141141
found := FansiteLanguagesRegex.FindAllString(subma1[0][7], -1)
142142
FansiteLanguagesData := make([]string, len(found))
143143
for i := range FansiteLanguagesData {
144-
FansiteLanguagesData[i] = strings.ReplaceAll(found[i], "iti__flag iti__", "")
144+
FansiteLanguagesData[i] = strings.ReplaceAll(found[i], "id=\"Language_", "")
145145
}
146146

147147
// Specials

src/TibiaFansitesV3_test.go

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ func TestFansites(t *testing.T) {
1717
fansitesJson := TibiaFansitesV3Impl(string(data))
1818
assert := assert.New(t)
1919

20-
assert.Equal(17, len(fansitesJson.Fansites.PromotedFansites))
20+
assert.Equal(18, len(fansitesJson.Fansites.PromotedFansites))
2121

22-
assert.Equal(22, len(fansitesJson.Fansites.SupportedFansites))
22+
assert.Equal(20, len(fansitesJson.Fansites.SupportedFansites))
2323

24-
tibiaDataFansite := fansitesJson.Fansites.SupportedFansites[6]
24+
tibiaDataFansite := fansitesJson.Fansites.SupportedFansites[5]
2525
assert.Equal("TibiaData.com", tibiaDataFansite.Name)
2626
assert.Equal("https://static.tibia.com/images/community/fansitelogos/TibiaData.com.gif", tibiaDataFansite.LogoURL)
2727
assert.Equal("https://tibiadata.com", tibiaDataFansite.Homepage)
@@ -30,23 +30,23 @@ func TestFansites(t *testing.T) {
3030
assert.False(tibiaDataFansite.ContentType.Texts)
3131
assert.True(tibiaDataFansite.ContentType.Tools)
3232
assert.False(tibiaDataFansite.ContentType.Wiki)
33-
assert.False(tibiaDataFansite.SocialMedia.Discord)
34-
assert.False(tibiaDataFansite.SocialMedia.Facebook)
33+
assert.True(tibiaDataFansite.SocialMedia.Discord)
34+
assert.True(tibiaDataFansite.SocialMedia.Facebook)
3535
assert.False(tibiaDataFansite.SocialMedia.Instagram)
3636
assert.False(tibiaDataFansite.SocialMedia.Reddit)
3737
assert.False(tibiaDataFansite.SocialMedia.Twitch)
38-
assert.False(tibiaDataFansite.SocialMedia.Twitter)
38+
assert.True(tibiaDataFansite.SocialMedia.Twitter)
3939
assert.False(tibiaDataFansite.SocialMedia.Youtube)
4040
assert.Equal(1, len(tibiaDataFansite.Languages))
41-
assert.Equal("us", tibiaDataFansite.Languages[0])
41+
assert.Equal("en", tibiaDataFansite.Languages[0])
4242
assert.Equal(3, len(tibiaDataFansite.Specials))
4343
assert.Equal("API for Tibia data in JSON.", tibiaDataFansite.Specials[0])
4444
assert.Equal("Discord server.", tibiaDataFansite.Specials[1])
4545
assert.Equal("GitHub participant.", tibiaDataFansite.Specials[2])
4646
assert.False(tibiaDataFansite.FansiteItem)
4747
assert.Equal("", tibiaDataFansite.FansiteItemURL)
4848

49-
tibiaGalleryFansite := fansitesJson.Fansites.SupportedFansites[9]
49+
tibiaGalleryFansite := fansitesJson.Fansites.SupportedFansites[8]
5050
assert.Equal("TibiaGallery.com", tibiaGalleryFansite.Name)
5151
assert.Equal("https://static.tibia.com/images/community/fansitelogos/TibiaGallery.com.gif", tibiaGalleryFansite.LogoURL)
5252
assert.Equal("https://tibiagallery.com/", tibiaGalleryFansite.Homepage)
@@ -63,14 +63,14 @@ func TestFansites(t *testing.T) {
6363
assert.False(tibiaGalleryFansite.SocialMedia.Twitter)
6464
assert.False(tibiaGalleryFansite.SocialMedia.Youtube)
6565
assert.Equal(9, len(tibiaGalleryFansite.Languages))
66-
assert.Equal("br", tibiaGalleryFansite.Languages[0])
67-
assert.Equal("pl", tibiaGalleryFansite.Languages[1])
68-
assert.Equal("mx", tibiaGalleryFansite.Languages[2])
69-
assert.Equal("us", tibiaGalleryFansite.Languages[3])
70-
assert.Equal("se", tibiaGalleryFansite.Languages[4])
71-
assert.Equal("de", tibiaGalleryFansite.Languages[5])
72-
assert.Equal("fi", tibiaGalleryFansite.Languages[6])
73-
assert.Equal("fr", tibiaGalleryFansite.Languages[7])
66+
assert.Equal("de", tibiaGalleryFansite.Languages[0])
67+
assert.Equal("en", tibiaGalleryFansite.Languages[1])
68+
assert.Equal("es", tibiaGalleryFansite.Languages[2])
69+
assert.Equal("fi", tibiaGalleryFansite.Languages[3])
70+
assert.Equal("fr", tibiaGalleryFansite.Languages[4])
71+
assert.Equal("pl", tibiaGalleryFansite.Languages[5])
72+
assert.Equal("pt", tibiaGalleryFansite.Languages[6])
73+
assert.Equal("sv", tibiaGalleryFansite.Languages[7])
7474
assert.Equal("tr", tibiaGalleryFansite.Languages[8])
7575
assert.Equal(1, len(tibiaGalleryFansite.Specials))
7676
assert.Equal("Upload, browse, like and share pictures.", tibiaGalleryFansite.Specials[0])

0 commit comments

Comments
 (0)