Skip to content

Commit 97a6784

Browse files
committed
fix character title that contains grade
1 parent 3a9683a commit 97a6784

File tree

3 files changed

+811
-1
lines changed

3 files changed

+811
-1
lines changed

src/TibiaCharactersCharacter.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ func TibiaCharactersCharacterImpl(BoxContentHTML string) (*CharacterResponse, er
190190
case "Sex:":
191191
CharacterInfoData.Sex = RowData
192192
case "Title:":
193-
leftParenIdx := strings.Index(RowData, "(")
193+
leftParenIdx := strings.LastIndex(RowData, "(")
194194
if leftParenIdx == -1 {
195195
return
196196
}

src/TibiaCharactersCharacter_test.go

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3005,6 +3005,35 @@ func TestNumber9(t *testing.T) {
30053005
assert.Equal(character.OtherCharacters[9].World, "Ferobra")
30063006
}
30073007

3008+
func TestNumber10(t *testing.T) {
3009+
file, err := static.TestFiles.Open("testdata/characters/Nocna Furia.html")
3010+
if err != nil {
3011+
t.Fatalf("file opening error: %s", err)
3012+
}
3013+
defer file.Close()
3014+
3015+
data, err := io.ReadAll(file)
3016+
if err != nil {
3017+
t.Fatalf("File reading error: %s", err)
3018+
}
3019+
3020+
characterJson, err := TibiaCharactersCharacterImpl(string(data))
3021+
if err != nil {
3022+
t.Fatal(err)
3023+
}
3024+
3025+
assert := assert.New(t)
3026+
character := characterJson.Character.CharacterInfo
3027+
3028+
assert.Equal("Nocna Furia", character.Name)
3029+
assert.Nil(character.FormerNames)
3030+
assert.False(character.Traded)
3031+
assert.Empty(character.DeletionDate)
3032+
assert.Equal("male", character.Sex)
3033+
assert.Equal("Tibia's Topmodel (Grade 1)", character.Title)
3034+
assert.Equal(6, character.UnlockedTitles)
3035+
}
3036+
30083037
func BenchmarkNumber1(b *testing.B) {
30093038
file, err := static.TestFiles.Open("testdata/characters/Darkside Rafa.html")
30103039
if err != nil {

0 commit comments

Comments
 (0)