Skip to content

Commit 599d30a

Browse files
phenpessoatobiasehlert
authored andcommitted
TibiaHousesHouse: reduce heap allocations
1 parent ecfb154 commit 599d30a

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/TibiaHousesHouse.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -72,20 +72,20 @@ var (
7272
)
7373

7474
// TibiaHousesHouse func
75-
func TibiaHousesHouseImpl(houseid int, BoxContentHTML string) (*HouseResponse, error) {
75+
func TibiaHousesHouseImpl(houseid int, BoxContentHTML string) (HouseResponse, error) {
7676
// Creating empty vars
7777
var HouseData House
7878

7979
// Loading HTML data into ReaderHTML for goquery with NewReader
8080
ReaderHTML, err := goquery.NewDocumentFromReader(strings.NewReader(BoxContentHTML))
8181
if err != nil {
82-
return nil, fmt.Errorf("[error] TibiaHousesHouseImpl failed at goquery.NewDocumentFromReader, err: %s", err)
82+
return HouseResponse{}, fmt.Errorf("[error] TibiaHousesHouseImpl failed at goquery.NewDocumentFromReader, err: %s", err)
8383
}
8484

8585
// Running query over each div
8686
HouseHTML, err := ReaderHTML.Find(".BoxContent table tr").First().Html()
8787
if err != nil {
88-
return nil, fmt.Errorf("[error] TibiaHousesHouseImpl failed at ReaderHTML.Find, err: %s", err)
88+
return HouseResponse{}, fmt.Errorf("[error] TibiaHousesHouseImpl failed at ReaderHTML.Find, err: %s", err)
8989
}
9090

9191
// Regex to get data for house
@@ -97,7 +97,7 @@ func TibiaHousesHouseImpl(houseid int, BoxContentHTML string) (*HouseResponse, e
9797

9898
rawHouse, err := validation.GetHouseRaw(HouseData.Houseid)
9999
if err != nil {
100-
return nil, err
100+
return HouseResponse{}, err
101101
}
102102

103103
HouseData.Town = rawHouse.Town
@@ -165,7 +165,7 @@ func TibiaHousesHouseImpl(houseid int, BoxContentHTML string) (*HouseResponse, e
165165
}
166166

167167
// Build the data-blob
168-
return &HouseResponse{
168+
return HouseResponse{
169169
HouseData,
170170
Information{
171171
APIDetails: TibiaDataAPIDetails,

0 commit comments

Comments
 (0)