remove return of loyalty title on no title (#98)

tobiasehlert · web-flow · commit 579283ecea05 · 2022-03-10T09:57:18.000+01:00
diff --git a/src/TibiaCharactersCharacterV3.go b/src/TibiaCharactersCharacterV3.go
@@ -246,7 +246,9 @@ func TibiaCharactersCharacterV3Impl(BoxContentHTML string) CharacterResponse {
 
 					CharacterInformationData.Comment = stringBuilder.String()
 				case "Loyalty Title:":
-					AccountInformationData.LoyaltyTitle = RowData
+					if RowData != "(no title)" {
+						AccountInformationData.LoyaltyTitle = RowData
+					}
 				case "Created:":
 					AccountInformationData.Created = TibiaDataDatetimeV3(RowData)
 				case "Position:":
diff --git a/src/TibiaCharactersCharacterV3_test.go b/src/TibiaCharactersCharacterV3_test.go
@@ -107,6 +107,7 @@ func TestNumber3(t *testing.T) {
 	assert.Equal("2022-03-08T00:09:13Z", characterJson.Characters.Character.DeletionDate)
 	assert.Equal("", characterJson.Characters.Character.LastLogin)
 	assert.Equal("Free Account", characterJson.Characters.Character.AccountStatus)
+	assert.Empty(characterJson.Characters.AccountInformation.LoyaltyTitle)
 }
 
 func TestNumber4(t *testing.T) {
diff --git a/testdata/characters/Borttagna Gubben.html b/testdata/characters/Borttagna Gubben.html

Original file line number	Diff line number	Diff line change
`@@ -107,6 +107,7 @@ func TestNumber3(t *testing.T) {`
`107`	`107`	`assert.Equal("2022-03-08T00:09:13Z", characterJson.Characters.Character.DeletionDate)`
`108`	`108`	`assert.Equal("", characterJson.Characters.Character.LastLogin)`
`109`	`109`	`assert.Equal("Free Account", characterJson.Characters.Character.AccountStatus)`
	`110`	`+ assert.Empty(characterJson.Characters.AccountInformation.LoyaltyTitle)`
`110`	`111`	`}`
`111`	`112`
`112`	`113`	`func TestNumber4(t *testing.T) {`