MdePkg/BasePeCoffLib: Fix use of uninitialized var after SafeIntLib fix #10688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SafeIntLib is only safe if it is used correctly, and if it signals an overflow, the error must be handled, rather than limping on and using garbage data from the stack, as this may turn out to be more dangerous than using the overflowed value. So initialize RelocBase and RelocBaseEnd to NULL first, as it will get tested even in case of overflow, and this will prevent it from being initialized as expected. Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
ardbiesheuvel
force-pushed
the
mdepkg-pecofflib-fix-uninit-relocbase
branch
from
009b58c to
ffdc267
Compare
lersek
approved these changes
Jan 28, 2025
|
PR can not be merged due to conflict. Please rebase and resubmit |
Member
|
This appears to be a duplicate of PR #10689 and should be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SafeIntLib is only safe if it is used correctly, and if it signals an overflow, the error must be handled, rather than limping on and using garbage data from the stack, as this may turn out to be more dangerous than using the overflowed value.
So initialize RelocBase to NULL as it will get tested even in case of overflow, and this will prevent it from being initialized as expected.