Skip to content

Commit cb30c8f

Browse files
Laszlo Ersekmergify[bot]
authored andcommitted
SecurityPkg/DxeImageVerificationLib: plug Data leak in IsForbiddenByDbx() (CVE-2019-14575)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1608 If the second GetVariable() call for "dbx" fails, in IsForbiddenByDbx(), we have to free Data. Jump to "Done" for that. Cc: Jiewen Yao <jiewen.yao@intel.com> Cc: Chao Zhang <chao.b.zhang@intel.com> Signed-off-by: Laszlo Ersek <lersek@redhat.com> Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
1 parent 5cd8be6 commit cb30c8f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1274,7 +1274,7 @@ IsForbiddenByDbx (
12741274

12751275
Status = gRT->GetVariable (EFI_IMAGE_SECURITY_DATABASE1, &gEfiImageSecurityDatabaseGuid, NULL, &DataSize, (VOID *) Data);
12761276
if (EFI_ERROR (Status)) {
1277-
return IsForbidden;
1277+
goto Done;
12781278
}
12791279

12801280
//

0 commit comments

Comments
 (0)