Remove incorrect addressof from InstallConfigurationTable sample #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makubacki
approved these changes
Mar 5, 2025
mdkinney
approved these changes
Mar 5, 2025
mdkinney
requested changes
Mar 5, 2025
Contributor
mdkinney
left a comment
mdkinney
left a comment
There was a problem hiding this comment.
Commit message requires Signed-off-by and Contributed-under tags
InstallConfigurationTable takes a pointer to a GUID and a pointer to a buffer. The sample passes the pointer to the pointer, which means the sample is wrong. When developers use this sample as the starting point for their code, they will have a bug that is very tricky to see in their code and tricky to diagnose. This issue wasted several hours of my time today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InstallConfigurationTable takes a pointer to a GUID and a pointer to a buffer.
The sample passes the pointer to the pointer, which means the sample is wrong.
When developers use this sample as the starting point for their code, they will have a bug that is very tricky to see in their code and tricky to diagnose.
This issue wasted several hours of my time today.
This fixes issue #5
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Doug Cook dcook@microsoft.com