Skip to content

marigold_ensemble integer fix #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

graemeniedermayer
Copy link
Contributor

@graemeniedermayer graemeniedermayer commented Dec 20, 2023

For the integer issue #388

This is probably the best place to cast to integers. Feel free to modify any other details.


The float16 does seem to be working. The vram significantly lower, although I keep getting an erroneous error message.

Pipelines loaded with `torch_dtype=torch.float16` cannot run with `cpu` device. It is not recommended to move them to `cpu` as running them will fail. Please make sure to use an accelerator to run the pipeline in inference, due to the lack of support for`float16` operations on this device in PyTorch. Please, remove the `torch_dtype=torch.float16` argument, or use another device for inference.

Hopefully this will be fixed by future marigold updates.

@graemeniedermayer graemeniedermayer changed the title Marigold_ensemble integer fix marigold_ensemble integer fix Dec 20, 2023
@semjon00
Copy link
Collaborator

semjon00 commented Dec 20, 2023

More of less ok. You should check existence in the list first. What if at some point it turns out that not all values are always passed?

@semjon00 semjon00 marked this pull request as ready for review December 21, 2023 17:31
@semjon00 semjon00 merged commit 0389f9e into thygate:marigold Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants