map mycelium to twin identity #1037
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omarabdul3ziz
force-pushed
the
development_TwinMycPK
branch
3 times, most recently
from
b557493 to
3fd0ab0
Compare
- add storage map from myc->twin - add setter method to update the storage which emit TwinMyceliumPkSet event - update rs/ts/go clients with setter/getter methods
Omarabdul3ziz
force-pushed
the
development_TwinMycPK
branch
from
3fd0ab0 to
e325c9f
Compare
This was referenced Jun 2, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a mapping between a mycelium public key and a twin identity by adding new storage, extrinsics, events, and updating client libraries.
- Adds a new storage map (MyceliumTwin) and setter extrinsic (set_mycelium_twin) that emits the MyceliumTwinUpdated event.
- Updates weights, benchmarking, and clients in Rust, JavaScript, and Go to support the new mapping functionality.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| substrate-node/pallets/pallet-tfgrid/src/weights.rs | Added weight calculation for the new extrinsic. |
| substrate-node/pallets/pallet-tfgrid/src/twin.rs | Introduced the internal setter _set_mycelium_twin with event emission. |
| substrate-node/pallets/pallet-tfgrid/src/lib.rs | Added storage definition and new extrinsic for mapping. |
| substrate-node/pallets/pallet-tfgrid/src/benchmarking.rs | Added benchmarks for the new extrinsic. |
| scripts/activate/man.go | Updated activation script (no direct mapping changes). |
| scripts/activate/go.mod | Added dependency changes for the activation module. |
| clients/tfchain-client-rs/* | Updated runtime client functions for setting/getting the mapping. |
| clients/tfchain-client-js/* | Updated twin module and client to support the new extrinsic. |
| clients/tfchain-client-go/* | Added new functions to map the mycelium public key to a twin. |
| clients/tfchain-client-go/events.go | Introduced the event struct MyceliumTwinUpdated. |
Comments suppressed due to low confidence (1)
substrate-node/pallets/pallet-tfgrid/src/twin.rs:412
- [nitpick] Consider renaming '_set_mycelium_twin' to a name without a leading underscore (e.g. 'set_mycelium_twin_inner') since it is a public function. This helps clarify its intended internal usage and avoids confusion with private functions.
pub fn _set_mycelium_twin(
This was referenced Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.