feat: store message as a shared constant char array (#108)

* feat: use `const char*` for the `msg` parameter in the `make` function

* feat: store `Error::message` as `std::shared_ptr<const char[]>`

* feat: use `std::string_view` for the `msg` parameter in the `make` function

* style: rename `Error::message_ptr` to `Error::msg_ptr`

Author: threeal

include/errors/error.hpp

@@ -13,9 +13,9 @@ namespace errors {
  */
 class [[nodiscard]] Error {
  private:
-  const std::shared_ptr<const std::string> message_ptr;
+  const std::shared_ptr<const char[]> msg_ptr;
 
-  Error(const std::shared_ptr<const std::string>& message_ptr);
+  Error(const std::shared_ptr<const char[]>& msg_ptr);
 
  public:
   /**
@@ -47,7 +47,7 @@ class [[nodiscard]] Error {
    */
   explicit operator bool() const;
 
-  friend Error make(const std::string& msg);
+  friend Error make(std::string_view msg);
   friend const Error& nil();
 
   /**
@@ -76,7 +76,7 @@ class [[nodiscard]] Error {
  * @param msg The error message.
  * @return A new error object.
  */
-Error make(const std::string& msg);
+Error make(std::string_view msg);
 
 
 /**

src/error.cpp

@@ -1,24 +1,28 @@
+#include <algorithm>
 #include <errors/error.hpp>
 
 namespace errors {
 
-Error::Error(const std::shared_ptr<const std::string>& message_ptr) : message_ptr(message_ptr) {}
+Error::Error(const std::shared_ptr<const char[]>& msg_ptr) : msg_ptr(msg_ptr) {}
 
 std::string_view Error::message() const {
-  if (!message_ptr) return "no error";
-  return *message_ptr;
+  if (!msg_ptr) return "no error";
+  return msg_ptr.get();
 }
 
 Error::operator bool() const {
-  return (bool)message_ptr;
+  return (bool)msg_ptr;
 }
 
 std::ostream& operator<<(std::ostream& os, const errors::Error& err) {
   return os << "error: " << err.message();
 }
 
-Error make(const std::string& msg) {
-  return Error(std::make_shared<const std::string>(msg));
+Error make(std::string_view msg) {
+  auto c_msg = new char[msg.size() + 1];
+  msg.copy(c_msg, msg.size());
+  c_msg[msg.size()] = 0;
+  return Error(std::shared_ptr<const char[]>(c_msg));
 }
 
 const Error& nil() {