Skip to content

Conversation

@donmccurdy
Copy link
Contributor

@donmccurdy donmccurdy commented Apr 4, 2023

Why

three.js r152+ will contain a number of changes related to color management, including:

  • Replace WebGLRenderer#outputEncoding with WebGLRenderer#outputColorSpace
  • Replace Texture#encoding with Texture#colorSpace
  • Replace WebGLRenderTarget 'encoding' option with 'colorSpace'
  • Change default renderer output to sRGB

What

This PR updates the affected properties to values for r152, based on mrdoob/three.js#23614. I've intentionally kept the deprecated properties in the type definitions with @deprecated tags, hoping this will make for an easier migration.

Checklist

  • Checked the target branch (current goes master, next goes dev)
  • Added myself to contributors table
  • Ready to be merged

Submitting as draft for now, until the upstream changes are merged. Ready for review. r152 will be released later this week.

@donmccurdy donmccurdy changed the title Update color space properties for three.js r152 Update color space type definitions for three.js r152 Apr 4, 2023
@donmccurdy donmccurdy marked this pull request as ready for review April 24, 2023 23:02
@Methuselah96 Methuselah96 mentioned this pull request Apr 28, 2023
38 tasks
Copy link
Contributor

@Methuselah96 Methuselah96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Methuselah96 Methuselah96 merged commit 2d84241 into three-types:dev Apr 30, 2023
@donmccurdy donmccurdy deleted the feat/colorSpace-v2 branch April 30, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants