Skip to content

Commit 6b2c054

Browse files
SCAL-241097 Fix for liveboard shound not rerender if parent component rerenders
1 parent facf4a5 commit 6b2c054

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/react/index.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,8 @@ const componentFactory = <T extends typeof TsEmbed, U extends EmbedProps, V exte
2323
(props: U, forwardedRef: React.MutableRefObject<InstanceType<T>>) => {
2424
const ref = React.useRef<HTMLDivElement>(null);
2525
const { className, ...embedProps } = props;
26-
const { viewConfig, listeners } = getViewPropsAndListeners<Omit<U, 'className'>, V>(
27-
embedProps,
28-
);
26+
const { viewConfig, listeners } = React.useMemo(() => getViewPropsAndListeners<Omit<U, 'className'>, V>(embedProps),
27+
[embedProps]);
2928

3029
const handleDestroy = (tsEmbed: InstanceType<T>) => {
3130
// do not destroy if it is a preRender component

0 commit comments

Comments
 (0)