Skip to content

feat(mocks): support non-span ref struct out/ref params #5878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 3 commits into from
May 10, 2026
Merged

feat(mocks): support non-span ref struct out/ref params #5878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ef22f7
feat(mocks): support non-span ref struct out/ref params
thomhurst May 10, 2026
9b9d37c
refactor(mocks): consolidate ref-struct setter helpers
thomhurst May 10, 2026
c21a47d
fix(mocks): suppress empty wrapper when ref-struct setter not emittable
thomhurst May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions TUnit.Mocks.SourceGenerator/Builders/MockBridgeBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ private static void BuildBridgeInterface(CodeWriter writer, MockTypeModel model,
if (!method.IsStaticAbstract) continue;
if (!first) writer.AppendLine();
first = false;
GenerateStaticMethodDim(writer, method, staticEngineTypeName);
GenerateStaticMethodDim(writer, method, staticEngineTypeName, model);
}

// Static abstract properties — provide DIM implementations
Expand Down Expand Up @@ -92,7 +92,7 @@ private static void BuildStaticEngineClass(CodeWriter writer, MockTypeModel mode
}
}

private static void GenerateStaticMethodDim(CodeWriter writer, MockMemberModel method, string staticEngineTypeName)
private static void GenerateStaticMethodDim(CodeWriter writer, MockMemberModel method, string staticEngineTypeName, MockTypeModel model)
{
var signatureReturnType = (method.IsVoid && !method.IsAsync) ? "void" : method.ReturnType;
var paramList = MockImplBuilder.GetParameterList(method);
Expand All @@ -103,7 +103,7 @@ private static void GenerateStaticMethodDim(CodeWriter writer, MockMemberModel m

using (writer.Block($"static {signatureReturnType} {method.ExplicitInterfaceName}.{EscapeIdentifier(method.Name)}{typeParams}({paramList}){constraints}"))
{
GenerateStaticEngineDispatchBody(writer, method, staticEngineTypeName);
GenerateStaticEngineDispatchBody(writer, method, staticEngineTypeName, model);
}
}

Expand Down Expand Up @@ -155,7 +155,7 @@ private static void GenerateStaticEventDim(CodeWriter writer, MockEventModel evt
writer.CloseBrace();
}

private static void GenerateStaticEngineDispatchBody(CodeWriter writer, MockMemberModel method, string staticEngineTypeName)
private static void GenerateStaticEngineDispatchBody(CodeWriter writer, MockMemberModel method, string staticEngineTypeName, MockTypeModel model)
{
writer.AppendLine($"var __engine = {staticEngineTypeName}.Engine;");

Expand All @@ -174,7 +174,7 @@ private static void GenerateStaticEngineDispatchBody(CodeWriter writer, MockMemb
{
writer.AppendLine("if (__engine is null) return;");
writer.AppendLine($"__engine.HandleCall({method.MemberId}, \"{method.Name}\", {argsArray});");
MockImplBuilder.EmitOutRefReadback(writer, method);
MockImplBuilder.EmitOutRefReadback(writer, method, model);
}
else if (method.IsVoid && method.IsAsync)
{
Expand All @@ -190,7 +190,7 @@ private static void GenerateStaticEngineDispatchBody(CodeWriter writer, MockMemb
using (writer.Block("try"))
{
writer.AppendLine($"__engine.HandleCall({method.MemberId}, \"{method.Name}\", {argsArray});");
MockImplBuilder.EmitOutRefReadback(writer, method);
MockImplBuilder.EmitOutRefReadback(writer, method, model);
if (method.IsValueTask)
{
writer.AppendLine("return default(global::System.Threading.Tasks.ValueTask);");
Expand Down Expand Up @@ -228,7 +228,7 @@ private static void GenerateStaticEngineDispatchBody(CodeWriter writer, MockMemb
using (writer.Block("try"))
{
writer.AppendLine($"var __result = ({method.UnwrappedReturnType})__engine.HandleCallWithReturn<object?>({method.MemberId}, \"{method.Name}\", {argsArray}, null)!;");
MockImplBuilder.EmitOutRefReadback(writer, method);
MockImplBuilder.EmitOutRefReadback(writer, method, model);
if (method.IsValueTask)
{
writer.AppendLine($"return new global::System.Threading.Tasks.ValueTask<{method.UnwrappedReturnType}>(__result);");
Expand Down Expand Up @@ -264,7 +264,7 @@ private static void GenerateStaticEngineDispatchBody(CodeWriter writer, MockMemb
using (writer.Block("try"))
{
writer.AppendLine($"var __result = __engine.HandleCallWithReturn<{method.UnwrappedReturnType}>({method.MemberId}, \"{method.Name}\", {argsArray}, {method.UnwrappedSmartDefault});");
MockImplBuilder.EmitOutRefReadback(writer, method);
MockImplBuilder.EmitOutRefReadback(writer, method, model);
if (method.IsValueTask)
{
writer.AppendLine($"return new global::System.Threading.Tasks.ValueTask<{method.UnwrappedReturnType}>(__result);");
Expand Down Expand Up @@ -292,14 +292,14 @@ private static void GenerateStaticEngineDispatchBody(CodeWriter writer, MockMemb
// Use object? and cast instead.
writer.AppendLine("if (__engine is null) return default!;");
writer.AppendLine($"var __result = __engine.HandleCallWithReturn<object?>({method.MemberId}, \"{method.Name}\", {argsArray}, null);");
MockImplBuilder.EmitOutRefReadback(writer, method);
MockImplBuilder.EmitOutRefReadback(writer, method, model);
writer.AppendLine($"return ({method.ReturnType})__result!;");
}
else
{
writer.AppendLine("if (__engine is null) return default!;");
writer.AppendLine($"var __result = __engine.HandleCallWithReturn<{method.ReturnType}>({method.MemberId}, \"{method.Name}\", {argsArray}, {method.SmartDefault});");
MockImplBuilder.EmitOutRefReadback(writer, method);
MockImplBuilder.EmitOutRefReadback(writer, method, model);
writer.AppendLine("return __result;");
}
}
Expand Down
Loading
Loading