-
-
Notifications
You must be signed in to change notification settings - Fork 111
fix: trigger module constructors for library assemblies #4621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
782bc46 to
b26d4f1
Compare
b26d4f1 to
d004089
Compare
Reset branch to main and reapply core changes only: - Changed from Assembly.Load() to typeof() references for library assemblies - Renamed AssembliesToLoad to TypesToReference in AssemblyInfoModel - Removed problematic TypeExtensions.cs changes that caused build errors This approach triggers module constructors without the complexity of assembly name resolution and avoids generic type parameter qualification issues.
c109a47 to
1ac29c0
Compare
- Prefer non-generic public types to avoid typeof() formatting complexity - Fallback to generic types with proper open generic syntax (<>, <,>, etc.) - Revert global.json SDK version to 10.0.102 This prevents compilation errors when the first public type in a library is generic, which would previously generate invalid typeof(Foo<T>) where T is not in scope.
This was referenced Jan 31, 2026
This was referenced Feb 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4583
Problem
[Before(TestSession)]hooks in library projects weren't executing. Library projects that reference TUnit.Core don't have source generation active, so they don't get generated ModuleInitializers to register their hooks.Solution
Reference a public type from each loaded library assembly using
typeof(), which triggers the assembly's module constructor to run and register hooks.Changes
_ = typeof(Fully.Qualified.TypeName);instead ofAssembly.Load()Why This Works
Referencing a type via
typeof()causes:This approach is cleaner than explicitly calling reflection-based hook discovery and avoids making internal APIs public.
Testing
Verified with the reproduction repository from #4583: