fix: address code fixer issues #4489 and #4607 #4609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
Contributor
|
No issues found. Checked for bugs and CLAUDE.md compliance. |
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
- Fix TUnit0059 false positive when abstract class has no subclasses (#4607) - Only warn when concrete subclasses exist but lack [InheritsTests] - Abstract classes designed for external consumption no longer trigger warnings - Fix NUnit Platform attribute conversion generating invalid code (#4489) - Correct OS.MacOS casing to OS.MacOs to match enum - Unsupported platforms (Mono, Net, NetCore) now left unconverted - Add Browser/wasm platform support - Add comprehensive test coverage for both fixes
Update migration guides to warn users that multi-targeting projects can cause code fixer crashes due to a Roslyn limitation. Changed from a "tip" to a "warning" and added clearer instructions with two options: 1. Specify --framework on command line 2. Temporarily modify project to single-target Relates to #4484, #4485
thomhurst
force-pushed
the
fix/code-fixer-issues-4489-4607
branch
from
b2264d1 to
5332931
Compare
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
This was referenced Jan 29, 2026
This was referenced Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix TUnit0059 false positive for abstract classes with no subclasses ([Bug]: TUnit0059 false positive when there are no subclasses in the same assembly #4607)
[InheritsTests]Fix NUnit Platform attribute conversion generating invalid code (Code fixer converts [Platform] attribute to non-existent [ExcludeOn(OS.X)] attribute #4489)
OS.MacOScasing toOS.MacOsto match the actual enum valueOS.MonoNote on multi-targeting issues (TUXU0001 code fixer fails with 'Changes must be within bounds of SourceText' on multi-targeting projects #4484, TUNU0001 code fixer crashes on multi-targeting projects #4485)
dotnet formatand linked filesLinkedFileDiffMergingSessionwhich is part of Roslyn, not TUnitTest plan
[InheritsTests](should warn)Fixes #4489
Fixes #4607
Related to #4484, #4485 (cannot fix - Roslyn limitation)