feat: add TUNIT_DISABLE_LOGO environment variable support#4576
feat: add TUNIT_DISABLE_LOGO environment variable support#4576
Conversation
Add support for configuring --disable-logo via the TUNIT_DISABLE_LOGO environment variable. This allows CI/CD pipelines and development environments to set defaults without modifying command-line arguments. Also adds comprehensive documentation for all TUnit environment variables. Closes #4574 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
SummaryAdds support for the Critical IssuesNone found ✅ Suggestions1. Environment Variable Value Checking Pattern InconsistencyThe implementation in Environment.GetEnvironmentVariable("TUNIT_DISABLE_LOGO") is not nullHowever, this differs from the more robust pattern used in However, consider documenting in export TUNIT_DISABLE_LOGO=true
export TUNIT_DISABLE_LOGO=1
export TUNIT_DISABLE_LOGO=false # This would ALSO disable the logo!The documentation currently shows only # Set to any value to disable the logo (presence of variable disables it)
export TUNIT_DISABLE_LOGO=12. Priority Order ClarificationThe documentation states command-line arguments take precedence, but the current implementation in if (commandLineOptions.IsOptionSet(DisableLogoCommandProvider.DisableLogo)
|| Environment.GetEnvironmentVariable("TUNIT_DISABLE_LOGO") is not nullThis means if either is set, the logo is disabled - which is the correct behavior. The documentation correctly describes this, so no code change needed. 3. Minor Documentation ConsistencyIn **Equivalent to:** `--disable-logo`Consider adding similar "Equivalent to:" sections for all other environment variables that have command-line equivalents (like Verdict✅ APPROVE - No critical issues. The implementation follows existing patterns in the codebase. The suggestions are minor documentation clarifications that could be addressed in a follow-up PR. |
Summary
TUNIT_DISABLE_LOGOenvironment variable support to disable the ASCII art logoCloses #4574
Changes
TUNIT_DISABLE_LOGOenvironment variable alongside the--disable-logocommand-line flag--disable-logocan also be set via environment variableTest plan
TUNIT_DISABLE_LOGO=truesuppresses the ASCII logo--disable-logostill works as before🤖 Generated with Claude Code