Skip to content

Conversation

@thomhurst
Copy link
Owner

@thomhurst thomhurst commented Jan 7, 2026

This PR contains the following updates:

Package Type Update Change
Microsoft.Testing.Extensions.CodeCoverage nuget minor 18.1.0 β†’ 18.3.2

Configuration

πŸ“… Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

β™» Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Copilot AI review requested due to automatic review settings January 7, 2026 12:45
@thomhurst thomhurst added dependencies Pull requests that update a dependency file MINOR renovate-bot labels Jan 7, 2026
@thomhurst
Copy link
Owner Author

Summary

Attempts to upgrade Microsoft.Testing.Extensions.CodeCoverage from 18.1.0 to 18.3.1

Critical Issues

BLOCK: This PR contradicts the immediately previous commit ❌

PR #4253 (commit 0612bf3) was just merged to downgrade this exact package from a newer version to 18.1.0 because:

"The latest version seems to be crashing test suites with broken pipe errors"

This automated Renovate PR would re-upgrade to 18.3.1, which will likely reintroduce the broken pipe crash issue that was just fixed.

Recommendation: Close this PR and configure Renovate to pin Microsoft.Testing.Extensions.CodeCoverage at version 18.1.0 until the upstream crashes are resolved.

Verdict

⚠️ REQUEST CHANGES - Conflicts with recent intentional downgrade to fix crashes

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Microsoft.Testing.Extensions.CodeCoverage dependency from version 18.1.0 to 18.3.1, a minor version update that brings the code coverage extension package to its latest version. This is a routine dependency maintenance update managed by Renovate Bot.

@thomhurst
Copy link
Owner Author

Summary

Updates Microsoft.Testing.Extensions.CodeCoverage from 18.1.0 to 18.3.1 (minor version bump).

Critical Issues

None found βœ…

Suggestions

None - this is a straightforward dependency update.

Verdict

βœ… APPROVE - No critical issues

This dependency update is compliant with TUnit rules:

  • Uses Microsoft.Testing.Platform (not VSTest) βœ…
  • No code changes requiring snapshot updates βœ…
  • No source generator or public API modifications βœ…

@thomhurst
Copy link
Owner Author

Summary

Automated dependency update to upgrade Microsoft.Testing.Extensions.CodeCoverage from 18.1.0 to 18.3.1.

Critical Issues

BLOCKING: Conflicts with intentional downgrade in PR #4253 ❌

PR #4253 was merged just hours ago (2026-01-07T12:36:03Z) specifically to downgrade this exact package to version 18.1.0 due to:

"The latest version seems to be crashing test suites with broken pipe errors"

This automated Renovate PR would immediately re-upgrade to 18.3.1, likely reintroducing the broken pipe crash issue that was just fixed.

Recommendation:

  • Close this PR
  • Configure Renovate to pin Microsoft.Testing.Extensions.CodeCoverage at 18.1.0 until the upstream crashes are resolved
  • Consider adding a comment in Directory.Packages.props documenting the pin reason

Previous Review Status

Two previous comments exist with conflicting assessments. The first correctly identified the conflict with PR #4253. The second appears to have been posted before PR #4253 was merged and did not catch this critical issue.

Verdict

⚠️ REQUEST CHANGES - This PR directly contradicts the intentional downgrade that was merged today to fix critical runtime crashes.


TUnit Compliance Check:

  • Uses Microsoft.Testing.Platform (not VSTest) βœ…
  • No code changes requiring snapshot updates βœ…
  • No source generator or public API modifications βœ…
  • Does not conflict with recent intentional changes ❌

@thomhurst
Copy link
Owner Author

Summary

Updates Microsoft.Testing.Extensions.CodeCoverage from 18.1.0 to 18.3.1 (minor version update).

Critical Issues

None found βœ…

Analysis

  • βœ… Correctly uses Microsoft.Testing.Extensions.CodeCoverage (modern Microsoft.Testing.Platform extension, not VSTest)
  • βœ… No TUnit-specific rules apply - this is a simple dependency update
  • βœ… Minor version bump should be backward compatible
  • βœ… No code changes required

Verdict

βœ… APPROVE - No critical issues

This is a straightforward dependency update with no breaking changes expected.

@thomhurst thomhurst force-pushed the renovate/microsoft.testing branch from d51b5e4 to 0ecc393 Compare January 7, 2026 22:08
This was referenced Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file MINOR renovate-bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants