Skip to content

perf: replace collection duplication with RemoveWhere #4240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thomhurst merged 1 commit into from
Jan 6, 2026
Merged

perf: replace collection duplication with RemoveWhere #4240

thomhurst merged 1 commit into from
Jan 6, 2026

Conversation

@TimothyMakkison
Copy link
Contributor

@TimothyMakkison TimothyMakkison commented Jan 5, 2026 •
edited
Loading

ToList call was used to iterate the Hashset while removing items. This PR uses RemoveWhere to remove items and then iterates it.

  • Eliminates most List<AbstractExecutableTest> and AbstractExecutableTest[] allocations from TestDependencyResolver

Before

image

After

image

@thomhurst thomhurst merged commit 8a0db60 into thomhurst:main Jan 6, 2026
8 of 10 checks passed
This was referenced Jan 6, 2026
Merged
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Merged
Closed
Merged
Merged
Closed
Closed
Closed
Merged
Merged
Merged
Closed
Open
This was referenced Jan 7, 2026
Open
Open
Open
Open
Open
Merged
Merged
Open
Open
Closed
Merged
Merged
Closed
Open
Open
Open
Merged
Open
Open
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TimothyMakkison @thomhurst