-
-
Notifications
You must be signed in to change notification settings - Fork 111
feat: implement dynamic attribute merging for test data collectors an… #4188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d add tests for inherited attributes
SummaryThis PR fixes dynamic tests to inherit attributes from their test class and assembly. Critical IssuesNone found ✅ SuggestionsPerformance: Attribute Collection AllocationThe new GetDynamicTestAttributes method creates a new List for every dynamic test during discovery (hot path). Consider:
Test Validation TimingIn DynamicTestInheritedAttributesTests line 78, the Task.Delay(100) seems fragile for detecting overlaps if tests run slowly. Consider more deterministic synchronization or longer buffer. Verdict✅ APPROVE - Implementation correctly fixes issue #4186 with proper dual-mode support and good test coverage. |
Fixes #4186