-
-
Notifications
You must be signed in to change notification settings - Fork 96
Playwright | additional constructor for page testing #3418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playwright | additional constructor for page testing #3418
Conversation
1dddb07 to
8bfe560
Compare
|
You need to update the public API snapshots too please |
|
Thanks for the feedback! Could you please clarify how I should update the public API snapshots? Is there a specific command or step I should follow? |
You just need to run the PublicAPI test project, and then you'll get failures due to snapshots needing updating. Then you can install this: |
…' into playwright-pagetest-constructors
Thank you for the information. The necessary action has been taken. |
This PR introduces changes that address the question under discussion.
With this update, users can now pass browser launch settings through the constructor when creating their own test classes by inheriting from the PageTest class.
For example, users can set Headless = false via the constructor to control the browser launch behavior according to their needs.
Motivation
The goal of this change is to provide more flexibility and configurability during browser initialization, improving the overall developer experience when working with PageTest-based tests.