Skip to content

Conversation

@AdemCatamak
Copy link
Contributor

This PR introduces changes that address the question under discussion.

With this update, users can now pass browser launch settings through the constructor when creating their own test classes by inheriting from the PageTest class.

For example, users can set Headless = false via the constructor to control the browser launch behavior according to their needs.

Motivation

The goal of this change is to provide more flexibility and configurability during browser initialization, improving the overall developer experience when working with PageTest-based tests.

@AdemCatamak AdemCatamak force-pushed the playwright-pagetest-constructors branch from 1dddb07 to 8bfe560 Compare October 16, 2025 20:45
@thomhurst
Copy link
Owner

You need to update the public API snapshots too please

@AdemCatamak
Copy link
Contributor Author

Thanks for the feedback! Could you please clarify how I should update the public API snapshots? Is there a specific command or step I should follow?

@thomhurst
Copy link
Owner

Thanks for the feedback! Could you please clarify how I should update the public API snapshots? Is there a specific command or step I should follow?

You just need to run the PublicAPI test project, and then you'll get failures due to snapshots needing updating.

Then you can install this: dotnet tool install -g verify.tool and then run dotnet verify accept -y. Then just commit the updated snapshots

@AdemCatamak
Copy link
Contributor Author

Thanks for the feedback! Could you please clarify how I should update the public API snapshots? Is there a specific command or step I should follow?

You just need to run the PublicAPI test project, and then you'll get failures due to snapshots needing updating.

Then you can install this: dotnet tool install -g verify.tool and then run dotnet verify accept -y. Then just commit the updated snapshots

Thank you for the information. The necessary action has been taken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants