Skip to content

Commit 5fa245c

Browse files
committed
Removes redundant property injection logic
Simplifies code by delegating property injection to SingleTestExecutor, which now handles it after instance creation. Improves maintainability and reduces duplication.
1 parent ed760d1 commit 5fa245c

File tree

2 files changed

+3
-21
lines changed

2 files changed

+3
-21
lines changed

TUnit.Core/GenericTestMetadata.cs

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -69,15 +69,7 @@ public override Func<ExecutableTestCreationContext, TestMetadata, AbstractExecut
6969

7070
if (classInstance != null)
7171
{
72-
// Apply property values using unified PropertyInjector
73-
await PropertyInjectionService.InjectPropertiesAsync(
74-
testContext,
75-
classInstance,
76-
PropertyDataSources,
77-
PropertyInjections,
78-
MethodMetadata,
79-
testContext.TestDetails.TestId);
80-
72+
// Property injection is handled by SingleTestExecutor after instance creation
8173
return classInstance;
8274
}
8375

@@ -130,15 +122,7 @@ await PropertyInjectionService.InjectPropertiesAsync(
130122

131123
var instance = InstanceFactory(typeArgs, context.ClassArguments ?? Array.Empty<object?>());
132124

133-
// Apply property values using unified PropertyInjector
134-
await PropertyInjectionService.InjectPropertiesAsync(
135-
testContext,
136-
instance,
137-
PropertyDataSources,
138-
PropertyInjections,
139-
MethodMetadata,
140-
testContext.TestDetails.TestId);
141-
125+
// Property injection is handled by SingleTestExecutor after instance creation
142126
return instance;
143127
};
144128

TUnit.Engine/Discovery/ReflectionTestMetadata.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,7 @@ async Task<object> CreateInstance(TestContext testContext)
101101
[
102102
]);
103103

104-
// Apply property values using unified PropertyInjector
105-
await PropertyInjectionService.InjectPropertiesAsync(context.Context, instance, metadata.PropertyDataSources, metadata.PropertyInjections, metadata.MethodMetadata, context.Context.TestDetails.TestId);
106-
104+
// Property injection is handled by SingleTestExecutor after instance creation
107105
return instance;
108106
}
109107

0 commit comments

Comments
 (0)