+semver:minor - #2804: Global After/AfterEvery hooks not executing (#2842)

The global After and AfterEvery hooks at Test, Class, and Assembly levels were not being executed after test completion. Only TestSession and TestDiscovery hooks were running.

Root cause: TestExecutor.cs was calling OnTestStartingAsync() for Before hooks but missing the corresponding OnTestCompletedAsync() call for After hooks.

Changes:
- Added OnTestCompletedAsync() call in TestExecutor after test execution
- Wrapped in try-finally to ensure RouteTestResult always executes
- Added comprehensive test coverage to verify all hook types execute

This ensures proper cleanup and resource disposal in test lifecycle.

Fixes #2804

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Claude <noreply@anthropic.com>

Author: thomhurst

Directory.Packages.props

@@ -94,4 +94,4 @@
     <PackageVersion Include="xunit.v3.assert" Version="3.0.0" />
     <PackageVersion Include="xunit.v3.extensibility.core" Version="3.0.0" />
   </ItemGroup>
-</Project>
+</Project>

KNOWN_ISSUES.md

@@ -0,0 +1,37 @@
+# Known Issues in TUnit
+
+## NotInParallel with Multiple Constraint Keys
+
+**Issue**: Tests with multiple `NotInParallel` constraint keys may run in parallel when they shouldn't.
+
+**Example**:
+```csharp
+[Test, NotInParallel(["GroupD", "GroupE"])]
+public async Task Test1() { }
+
+[Test, NotInParallel(["GroupD", "GroupF"])]  
+public async Task Test2() { }
+```
+
+Test1 and Test2 share "GroupD" and should not run in parallel, but they might.
+
+**Root Cause**: 
+The current implementation adds tests with multiple keys to separate queues for each key. Each queue is processed independently in parallel. This means:
+- GroupD queue will run Test1 and Test2 sequentially
+- But GroupE queue (processing Test1) and GroupF queue (processing Test2) may run concurrently
+- There's no cross-queue coordination to prevent tests sharing any constraint from overlapping
+
+**Workaround**:
+- Use single constraint keys per test
+- Or group related tests in the same test class with a class-level `NotInParallel` attribute
+
+**Fix Required**:
+The scheduler needs to track running tests across all queues and check for shared constraints before starting any test. This requires significant changes to the scheduling algorithm in `TestScheduler.cs` and `TestGroupingService.cs`.
+
+## Assembly-Level Hooks Affecting Unrelated Tests
+
+**Issue**: Assembly-level hooks (e.g., `[AfterEvery(Assembly)]`) run for ALL tests in the assembly, which can cause unexpected failures when hooks from test-specific scenarios affect other tests.
+
+**Workaround**: 
+- Avoid using assembly-level hooks in test files that intentionally throw exceptions
+- Or add proper filtering in the hooks to only run for specific test namespaces/classes

TUnit.Core.SourceGenerator.Tests/AbstractTests.Concrete1.verified.txt

@@ -32,12 +32,6 @@ internal sealed class ConcreteClass1_AssertClassName_TestSource_GUID : global::T
             PropertyInjections = new global::TUnit.Core.PropertyInjectionData[]
             {
             },
-            ParameterTypes = new global::System.Type[]
-            {
-            },
-            TestMethodParameterTypes = new string[]
-            {
-            },
             MethodMetadata = new global::TUnit.Core.MethodMetadata
             {
                 Type = typeof(global::TUnit.TestProject.AbstractTests.AbstractBaseClass),

TUnit.Core.SourceGenerator.Tests/AbstractTests.Concrete2.verified.txt

@@ -33,12 +33,6 @@ internal sealed class ConcreteClass2_SecondTest_TestSource_GUID : global::TUnit.
             PropertyInjections = new global::TUnit.Core.PropertyInjectionData[]
             {
             },
-            ParameterTypes = new global::System.Type[]
-            {
-            },
-            TestMethodParameterTypes = new string[]
-            {
-            },
             MethodMetadata = new global::TUnit.Core.MethodMetadata
             {
                 Type = typeof(global::TUnit.TestProject.AbstractTests.ConcreteClass2),
@@ -136,12 +130,6 @@ internal sealed class ConcreteClass2_AssertClassName_TestSource_GUID : global::T
             PropertyInjections = new global::TUnit.Core.PropertyInjectionData[]
             {
             },
-            ParameterTypes = new global::System.Type[]
-            {
-            },
-            TestMethodParameterTypes = new string[]
-            {
-            },
             MethodMetadata = new global::TUnit.Core.MethodMetadata
             {
                 Type = typeof(global::TUnit.TestProject.AbstractTests.AbstractBaseClass),
@@ -237,12 +225,6 @@ internal sealed class ConcreteClass2_SecondTest_TestSource_GUID : global::TUnit.
             PropertyInjections = new global::TUnit.Core.PropertyInjectionData[]
             {
             },
-            ParameterTypes = new global::System.Type[]
-            {
-            },
-            TestMethodParameterTypes = new string[]
-            {
-            },
             MethodMetadata = new global::TUnit.Core.MethodMetadata
             {
                 Type = typeof(global::TUnit.TestProject.AbstractTests.ConcreteClass2),
@@ -339,12 +321,6 @@ internal sealed class ConcreteClass1_AssertClassName_TestSource_GUID : global::T
             PropertyInjections = new global::TUnit.Core.PropertyInjectionData[]
             {
             },
-            ParameterTypes = new global::System.Type[]
-            {
-            },
-            TestMethodParameterTypes = new string[]
-            {
-            },
             MethodMetadata = new global::TUnit.Core.MethodMetadata
             {
                 Type = typeof(global::TUnit.TestProject.AbstractTests.AbstractBaseClass),

TUnit.Core.SourceGenerator.Tests/AfterAllTests.Test.verified.txt

@@ -31,12 +31,6 @@ internal sealed class CleanupTests_Test1_TestSource_GUID : global::TUnit.Core.In
             PropertyInjections = new global::TUnit.Core.PropertyInjectionData[]
             {
             },
-            ParameterTypes = new global::System.Type[]
-            {
-            },
-            TestMethodParameterTypes = new string[]
-            {
-            },
             MethodMetadata = new global::TUnit.Core.MethodMetadata
             {
                 Type = typeof(global::TUnit.TestProject.AfterTests.CleanupTests),
@@ -130,12 +124,6 @@ internal sealed class CleanupTests_Test2_TestSource_GUID : global::TUnit.Core.In
             PropertyInjections = new global::TUnit.Core.PropertyInjectionData[]
             {
             },
-            ParameterTypes = new global::System.Type[]
-            {
-            },
-            TestMethodParameterTypes = new string[]
-            {
-            },
             MethodMetadata = new global::TUnit.Core.MethodMetadata
             {
                 Type = typeof(global::TUnit.TestProject.AfterTests.CleanupTests),

TUnit.Core.SourceGenerator.Tests/AfterTests.Test.verified.txt

@@ -31,12 +31,6 @@ internal sealed class CleanupTests_Test1_TestSource_GUID : global::TUnit.Core.In
             PropertyInjections = new global::TUnit.Core.PropertyInjectionData[]
             {
             },
-            ParameterTypes = new global::System.Type[]
-            {
-            },
-            TestMethodParameterTypes = new string[]
-            {
-            },
             MethodMetadata = new global::TUnit.Core.MethodMetadata
             {
                 Type = typeof(global::TUnit.TestProject.AfterTests.CleanupTests),
@@ -130,12 +124,6 @@ internal sealed class CleanupTests_Test2_TestSource_GUID : global::TUnit.Core.In
             PropertyInjections = new global::TUnit.Core.PropertyInjectionData[]
             {
             },
-            ParameterTypes = new global::System.Type[]
-            {
-            },
-            TestMethodParameterTypes = new string[]
-            {
-            },
             MethodMetadata = new global::TUnit.Core.MethodMetadata
             {
                 Type = typeof(global::TUnit.TestProject.AfterTests.CleanupTests),

TUnit.Core.SourceGenerator.Tests/ArgsAsArrayTests.Test.verified.txt

@@ -33,14 +33,6 @@ internal sealed class ArgsAsArrayTests_Params_TestSource_GUID : global::TUnit.Co
             PropertyInjections = new global::TUnit.Core.PropertyInjectionData[]
             {
             },
-            ParameterTypes = new global::System.Type[]
-            {
-                typeof(string[]),
-            },
-            TestMethodParameterTypes = new string[]
-            {
-                "string[]",
-            },
             MethodMetadata = new global::TUnit.Core.MethodMetadata
             {
                 Type = typeof(global::TUnit.TestProject.ArgsAsArrayTests),
@@ -199,14 +191,6 @@ internal sealed class ArgsAsArrayTests_NonParams_TestSource_GUID : global::TUnit
             PropertyInjections = new global::TUnit.Core.PropertyInjectionData[]
             {
             },
-            ParameterTypes = new global::System.Type[]
-            {
-                typeof(string[]),
-            },
-            TestMethodParameterTypes = new string[]
-            {
-                "string[]",
-            },
             MethodMetadata = new global::TUnit.Core.MethodMetadata
             {
                 Type = typeof(global::TUnit.TestProject.ArgsAsArrayTests),
@@ -329,14 +313,6 @@ internal sealed class ArgsAsArrayTests_ParamsEnumerable_TestSource_GUID : global
             PropertyInjections = new global::TUnit.Core.PropertyInjectionData[]
             {
             },
-            ParameterTypes = new global::System.Type[]
-            {
-                typeof(global::System.Collections.Generic.IEnumerable<string>),
-            },
-            TestMethodParameterTypes = new string[]
-            {
-                "global::System.Collections.Generic.IEnumerable<string>",
-            },
             MethodMetadata = new global::TUnit.Core.MethodMetadata
             {
                 Type = typeof(global::TUnit.TestProject.ArgsAsArrayTests),
@@ -495,14 +471,6 @@ internal sealed class ArgsAsArrayTests_Enumerable_TestSource_GUID : global::TUni
             PropertyInjections = new global::TUnit.Core.PropertyInjectionData[]
             {
             },
-            ParameterTypes = new global::System.Type[]
-            {
-                typeof(global::System.Collections.Generic.IEnumerable<string>),
-            },
-            TestMethodParameterTypes = new string[]
-            {
-                "global::System.Collections.Generic.IEnumerable<string>",
-            },
             MethodMetadata = new global::TUnit.Core.MethodMetadata
             {
                 Type = typeof(global::TUnit.TestProject.ArgsAsArrayTests),
@@ -625,16 +593,6 @@ internal sealed class ArgsAsArrayTests_Following_Non_Params_TestSource_GUID : gl
             PropertyInjections = new global::TUnit.Core.PropertyInjectionData[]
             {
             },
-            ParameterTypes = new global::System.Type[]
-            {
-                typeof(int),
-                typeof(global::System.Collections.Generic.IEnumerable<string>),
-            },
-            TestMethodParameterTypes = new string[]
-            {
-                "int",
-                "global::System.Collections.Generic.IEnumerable<string>",
-            },
             MethodMetadata = new global::TUnit.Core.MethodMetadata
             {
                 Type = typeof(global::TUnit.TestProject.ArgsAsArrayTests),

TUnit.Core.SourceGenerator.Tests/ArgumentWithImplicitConverterTests.Test.verified.txt

@@ -38,14 +38,6 @@ internal sealed class ArgumentWithImplicitConverterTests_Explicit_TestSource_GUI
             PropertyInjections = new global::TUnit.Core.PropertyInjectionData[]
             {
             },
-            ParameterTypes = new global::System.Type[]
-            {
-                typeof(global::TUnit.TestProject.ExplicitInteger),
-            },
-            TestMethodParameterTypes = new string[]
-            {
-                "global::TUnit.TestProject.ExplicitInteger",
-            },
             MethodMetadata = new global::TUnit.Core.MethodMetadata
             {
                 Type = typeof(global::TUnit.TestProject.ArgumentWithImplicitConverterTests),
@@ -173,14 +165,6 @@ internal sealed class ArgumentWithImplicitConverterTests_Implicit_TestSource_GUI
             PropertyInjections = new global::TUnit.Core.PropertyInjectionData[]
             {
             },
-            ParameterTypes = new global::System.Type[]
-            {
-                typeof(global::TUnit.TestProject.ImplicitInteger),
-            },
-            TestMethodParameterTypes = new string[]
-            {
-                "global::TUnit.TestProject.ImplicitInteger",
-            },
             MethodMetadata = new global::TUnit.Core.MethodMetadata
             {
                 Type = typeof(global::TUnit.TestProject.ArgumentWithImplicitConverterTests),

TUnit.Core.SourceGenerator.Tests/AssemblyLoaderTests.Test.DotNet8_0.verified.txt

@@ -31,12 +31,6 @@ internal sealed class BasicTests_SynchronousTest_TestSource_GUID : global::TUnit
             PropertyInjections = new global::TUnit.Core.PropertyInjectionData[]
             {
             },
-            ParameterTypes = new global::System.Type[]
-            {
-            },
-            TestMethodParameterTypes = new string[]
-            {
-            },
             MethodMetadata = new global::TUnit.Core.MethodMetadata
             {
                 Type = typeof(global::TUnit.TestProject.BasicTests),
@@ -132,12 +126,6 @@ internal sealed class BasicTests_AsynchronousTest_TestSource_GUID : global::TUni
             PropertyInjections = new global::TUnit.Core.PropertyInjectionData[]
             {
             },
-            ParameterTypes = new global::System.Type[]
-            {
-            },
-            TestMethodParameterTypes = new string[]
-            {
-            },
             MethodMetadata = new global::TUnit.Core.MethodMetadata
             {
                 Type = typeof(global::TUnit.TestProject.BasicTests),
@@ -231,12 +219,6 @@ internal sealed class BasicTests_ValueTaskAsynchronousTest_TestSource_GUID : glo
             PropertyInjections = new global::TUnit.Core.PropertyInjectionData[]
             {
             },
-            ParameterTypes = new global::System.Type[]
-            {
-            },
-            TestMethodParameterTypes = new string[]
-            {
-            },
             MethodMetadata = new global::TUnit.Core.MethodMetadata
             {
                 Type = typeof(global::TUnit.TestProject.BasicTests),

TUnit.Core.SourceGenerator.Tests/AssemblyLoaderTests.Test.DotNet9_0.verified.txt

@@ -31,12 +31,6 @@ internal sealed class BasicTests_SynchronousTest_TestSource_GUID : global::TUnit
             PropertyInjections = new global::TUnit.Core.PropertyInjectionData[]
             {
             },
-            ParameterTypes = new global::System.Type[]
-            {
-            },
-            TestMethodParameterTypes = new string[]
-            {
-            },
             MethodMetadata = new global::TUnit.Core.MethodMetadata
             {
                 Type = typeof(global::TUnit.TestProject.BasicTests),
@@ -132,12 +126,6 @@ internal sealed class BasicTests_AsynchronousTest_TestSource_GUID : global::TUni
             PropertyInjections = new global::TUnit.Core.PropertyInjectionData[]
             {
             },
-            ParameterTypes = new global::System.Type[]
-            {
-            },
-            TestMethodParameterTypes = new string[]
-            {
-            },
             MethodMetadata = new global::TUnit.Core.MethodMetadata
             {
                 Type = typeof(global::TUnit.TestProject.BasicTests),
@@ -231,12 +219,6 @@ internal sealed class BasicTests_ValueTaskAsynchronousTest_TestSource_GUID : glo
             PropertyInjections = new global::TUnit.Core.PropertyInjectionData[]
             {
             },
-            ParameterTypes = new global::System.Type[]
-            {
-            },
-            TestMethodParameterTypes = new string[]
-            {
-            },
             MethodMetadata = new global::TUnit.Core.MethodMetadata
             {
                 Type = typeof(global::TUnit.TestProject.BasicTests),