Skip to content

Conversation

@Neintonine
Copy link
Contributor

When checking out the lumens style I found some components did not fit the semi-3D style, so I wanted to change that :)

Total list of components affected:

  • listgroups
  • cards
  • accordions
  • modals
  • toasts
  • popovers

@thomaspark
Copy link
Owner

Looks good, can you just fix these CSS lint errors from npm run test?

 333:6   ✖  Expected newline after ","  stylistic/selector-list-comma-newline-after
 333:22  ✖  Expected newline after ","  stylistic/selector-list-comma-newline-after
 333:32  ✖  Expected newline after ","  stylistic/selector-list-comma-newline-after
 338:27  ✖  Expected newline after ","  stylistic/selector-list-comma-newline-after

@Neintonine Neintonine force-pushed the fix/lumen-improve-cards-and-similar branch from 492d0f5 to 66dd167 Compare October 27, 2025 10:31
@Neintonine
Copy link
Contributor Author

Linting errors fixed :)

@Neintonine Neintonine force-pushed the fix/lumen-improve-cards-and-similar branch from 66dd167 to 18dccbd Compare October 27, 2025 10:49
@Neintonine
Copy link
Contributor Author

Had to force push, since I had an incorrect user on the commit, so I wanted to fix it :)

@thomaspark thomaspark merged commit 81c6027 into thomaspark:v5 Oct 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants