Added support for custom cache key provider #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice idea. I gonna have a review asap. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
@steuic I added some unit tests. Can you please have a look at the test ShouldGetKey_WithoutMatchingHeader. I think something is going wrong there. The current output key is |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
@steuic you can check the latest pre-release nuget. Your change should be part of it. |
|
Thank you Thomas.
👍
…________________________________
From: Thomas Galliker ***@***.***>
Sent: Saturday, May 7, 2022 1:06:53 PM
To: thomasgalliker/HttpClient.Caching ***@***.***>
Cc: steuic ***@***.***>; Mention ***@***.***>
Subject: Re: [thomasgalliker/HttpClient.Caching] Added support for custom cache key provider (PR #10)
@steuic<https://github.com/steuic> you can check the latest pre-release nuget. Your change should be part of it.
—
Reply to this email directly, view it on GitHub<#10 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AIAQBQYFBHOVZQPK3XEPNULVIZFE3ANCNFSM5M2OJ3PA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InMemoryCacheHandler now supports custom cache key provider.
Custom cache key provider and already implemented cache key providers
Interface
ICacheKeysProviderallow to implement custom cache key providers.Provider
DefaultCacheKeysProviderprovides cache key by concatenation of http method (GET or HEAD) and uri.Provider
MethodUriHeadersCacheKeysProviderprovides cache key by concatenation of http method (GET or HEAD), specific http headers and uri.Backward compatibility
When no custom cache key provider is specified, InMemoryCacheHandler will use
DefaultCacheKeysProviderwhich resemble previous cache key composition strategy: concatenation of http method (GET or HEAD) and uri. This allow backward compatibility.