Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the expected return of the readMap arguments when the source map doesn't exist? #82

Open
ericmorand-sonarsource opened this issue Jul 2, 2024 · 0 comments

Comments

@ericmorand-sonarsource
Copy link

Methods fromMapFileComment and fromMapFileSource take a readMap function as second argument, that is expected to return either a string or a Promise of a string. But it is not clear how this method is supposed to behave when the passed file doesn't exist?

Should it throw? Or return null?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant