Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rogue sourceMappingURL comment trips up devtools #50

Closed
dongryphon opened this issue Dec 17, 2016 · 1 comment
Closed

Rogue sourceMappingURL comment trips up devtools #50

dongryphon opened this issue Dec 17, 2016 · 1 comment

Comments

@dongryphon
Copy link

See https://github.com/thlorenz/convert-source-map/blob/master/index.js#L8

  //Example (Extra space between slashes added to solve Safari bug. Exclude space in production):
  //     / /# sourceMappingURL=foo.js.map           /*# sourceMappingURL=foo.js.map */
  /(?:\/\/[@#][ \t]+sourceMappingURL=([^\s'"]+?)[ \t]*$)|(?:\/\*[@#][ \t]+sourceMappingURL=([^\*]+?)[ \t]*(?:\*\/){1}[ \t]*$)/mg

The comment is generating a 404 in devtool and it is shutting down immediately when trying to debug.

It would be great if you change the comment so it doesn't match the regex and make the debugger thing there is a foo.js.map file :)

Thanks!

See also evanw/node-source-map-support#156 for the same report

@thlorenz
Copy link
Owner

thlorenz commented Apr 7, 2017

Sorry, seems to be a chrome devtools bug.
Why would you open it up anyways unless you're trying to debug this module?

At any rate, nothing we can fix here .. better to file a bug with the chrome people.

@thlorenz thlorenz closed this as completed Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants