-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute addresses with ref contracts #5699
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: f1a5555 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5699 +/- ##
==========================================
- Coverage 53.20% 53.12% -0.09%
==========================================
Files 1101 1103 +2
Lines 59100 59264 +164
Branches 4817 4826 +9
==========================================
+ Hits 31447 31482 +35
- Misses 26936 27064 +128
- Partials 717 718 +1
*This pull request uses carry forward flags. Click here to find out more.
|
This PR has been inactive for 30 days. It is now marked as stale and will be closed in 5 days if no further activity occurs. |
TOOL-2796 (XPROT-934)
Problem solved
This was an issue when installing modules published with ref contracts. Module installation goes through infra deployment functions which use computed addresses.
SDK should process ref contracts when computing published contract addresses.
PR-Codex overview
This PR focuses on enhancing the handling of published contract references in the
thirdweb
library by introducing new functions to compute addresses for these references, improving the deployment process for contracts.Detailed summary
processRefDeployments
function to handle contract references in constructor parameters.computeRefDeployments
function to compute addresses for published contract references.computeDeploymentInfoFromMetadata
to process constructor parameters usingcomputeRefDeployments
.computeRefDeployments
.