Skip to content

Docs(update): Correcting the Modular contract getting started tutoria… #5074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

cromewar
Copy link
Contributor

@cromewar cromewar commented Oct 17, 2024

…ls with updated code

Problem solved

Updating the code for Deploying a modular contract with corrected docs.


PR-Codex overview

This PR focuses on updating the CounterCore and CounterModule contracts for better integration with the Thirdweb modular contracts, enhancing functionality, and improving code structure.

Detailed summary

  • Changed license from UNLICENSED to MIT.
  • Updated import paths for Core and Module contracts to use @thirdweb-dev.
  • Added a constructor to CounterCore for owner initialization.
  • Implemented getSupportedCallbackFunctions in CounterCore.
  • Introduced BeforeIncrementCallback interface.
  • Enhanced increment function in CounterCore.
  • Added CounterStorage library for state management.
  • Implemented fallback functions in CounterModule for getStep and setStep.
  • Added beforeIncrement callback function in CounterModule.
  • Set up getModuleConfig function to communicate with core contract.
  • Included notes on callback functions and storage layout.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Oct 17, 2024

⚠️ No Changeset found

Latest commit: 91b6178

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 17, 2024

@cromewar is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Oct 17, 2024
Copy link
Contributor

graphite-app bot commented Oct 17, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 10:02pm

@jnsdls jnsdls merged commit 17127d7 into thirdweb-dev:main Oct 18, 2024
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants