From 350c58e01115d948f9806ef8a556714d8b7bf8ba Mon Sep 17 00:00:00 2001 From: Adam Majmudar Date: Mon, 7 Aug 2023 12:39:45 -0700 Subject: [PATCH] Update github actions to use secret key --- .github/workflows/run-tests.yml | 4 ++-- Makefile | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index ac2b89d..64d23fd 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -1,6 +1,7 @@ name: Build & Test env: SDK_ALCHEMY_KEY: ${{ secrets.SDK_ALCHEMY_KEY }} + THIRDWEB_SECRET_KEY: ${{ secrets.THIRDWEB_SECRET_KEY }} on: [push, pull_request] jobs: @@ -19,7 +20,7 @@ jobs: uses: actions/setup-go@v2 with: go-version: ${{ matrix.go-version }} - + - name: Use Node.js uses: actions/setup-node@v1 with: @@ -30,4 +31,3 @@ jobs: - name: Test run: yarn add hardhat && make test - diff --git a/Makefile b/Makefile index c3cd21a..c1814e0 100644 --- a/Makefile +++ b/Makefile @@ -128,8 +128,6 @@ stop-docker: docker rm hardhat-node test: FORCE - @echo "SDK_ALCHEMY_KEY = $$SDK_ALCHEMY_KEY" - @echo "THIRDWEB_SECRET_KEY = $$THIRDWEB_SECRET_KEY" docker build . -t hardhat-mainnet-fork docker start hardhat-node || docker run --name hardhat-node -d -p 8545:8545 -e "THIRDWEB_SECRET_KEY=${THIRDWEB_SECRET_KEY}" -e "SDK_ALCHEMY_KEY=${SDK_ALCHEMY_KEY}" hardhat-mainnet-fork sudo bash ./scripts/test/await-hardhat.sh