dont allow secret key for IAW flow

[joaquim-verges]

Summary by CodeRabbit

• Refactor
  • Updated internal error handling to use a more descriptive structure for error messages.
  • Simplified extraction of signing credentials from headers, now requiring specific headers and providing clearer validation errors if missing.

No changes to user-facing features or functionality.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes update error handling and authentication extraction logic. The IAWError::ApiError enum variant is refactored from a tuple to a struct variant, with corresponding updates to its usage. Authentication extraction logic is simplified, enforcing required headers and removing obsolete branches. No public API signatures are otherwise altered.

Changes

File(s)	Change Summary
server/src/http/error.rs	Updated pattern matching for IAWError::ApiError to use struct-like syntax.
server/src/http/extractors.rs	Simplified extraction logic for signing credentials; enforced required headers and removed a branch.
thirdweb-core/src/iaw/mod.rs	Refactored IAWError::ApiError from tuple to struct variant and updated all usages accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant HTTP Extractor
    participant SigningCredential

    Client->>HTTP Extractor: Send request with headers
    HTTP Extractor->>HTTP Extractor: Check for x-wallet-access-token
    alt Token present
        HTTP Extractor->>HTTP Extractor: Extract x-thirdweb-client-id and x-thirdweb-service-key
        alt Headers missing
            HTTP Extractor->>Client: Return validation error
        else All headers present
            HTTP Extractor->>SigningCredential: Construct Iaw(ClientIdServiceKey)
            HTTP Extractor->>Client: Return SigningCredential
        end
    else Token not present
        HTTP Extractor->>SigningCredential: Fallback to vault credentials
        HTTP Extractor->>Client: Return SigningCredential
    end

Loading

sequenceDiagram
    participant IAWClient
    participant API
    participant ErrorHandler

    IAWClient->>API: Make HTTP request
    API-->>IAWClient: Respond with JSON
    alt Error in response
        IAWClient->>ErrorHandler: Return IAWError::ApiError { message }
    else Success
        IAWClient->>IAWClient: Process response
    end

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d577f7 and 963e259.

📒 Files selected for processing (3)

• server/src/http/error.rs (1 hunks)
• server/src/http/extractors.rs (1 hunks)
• thirdweb-core/src/iaw/mod.rs (11 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.