Added benchmark tests for smart-wallet #535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alfheimrShiven thanks for the PR! |
Sure @kumaryash90. Thanks for the update. |
Codecov ReportAll modified lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
auto-merge was automatically disabled
October 16, 2023 22:46
Merge queue setting changed
|
@alfheimrShiven Could you give me permission to push to your branch? We are good to merge, I just fixed a few things to align with our recent signer perms changes. |
kumaryash90
approved these changes
Oct 18, 2023
Hey @WhiteOakKong I guess @kumaryash90 has incorporated the change. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes benchmark tests for non-upgradable smart accounts. Following are the gas measurements:
PASS] test_state_accountReceivesNativeTokens() (gas: 11012)
[PASS] test_state_addAndWithdrawDeposit() (gas: 83248)
[PASS] test_state_contractMetadata() (gas: 59240)
[PASS] test_state_createAccount_viaEntrypoint() (gas: 428384)
[PASS] test_state_createAccount_viaFactory() (gas: 334603)
[PASS] test_state_executeBatchTransaction() (gas: 40271)
[PASS] test_state_executeBatchTransaction_viaAccountSigner() (gas: 392267)
[PASS] test_state_executeBatchTransaction_viaEntrypoint() (gas: 83624)
[PASS] test_state_executeTransaction() (gas: 35783)
[PASS] test_state_executeTransaction_viaAccountSigner() (gas: 377498)
[PASS] test_state_executeTransaction_viaEntrypoint() (gas: 75957)
[PASS] test_state_receiveERC1155NFT() (gas: 39331)
[PASS] test_state_receiveERC721NFT() (gas: 78307)
[PASS] test_state_transferOutsNativeTokens() (gas: 82073)